Commit graph

1580 commits

Author SHA1 Message Date
Ceikry
f94fb24608 Fixed bug that could cause bank to throw index out of bounds and vanish items when rearranging tabs with completely full bank 2022-07-03 07:23:47 +00:00
vddcore
2846ff7172 Fixed seemingly random server crashes caused by ArrayIndexOutOfBoundsException on unsafe type during threaded operations by synchronizing add/remove logic for PulseRunner.TASKS 2022-07-03 07:20:24 +00:00
vddcore
350a2964ce Added the missing sound effect for when a tree is felled after a successful woodcutting attempt
Sound can be heard by other players nearby
2022-07-03 06:43:38 +00:00
vddcore
7a2f91df3d Fixed the long missing Lumbridge Achivement Diary store-browsing task 2022-07-03 06:37:34 +00:00
Ceikry
7cded916c6 Fixed an exception thrown by the equipment interface 2022-07-03 06:36:04 +00:00
bushtail
16353eda20 Converted EnchantedGemPlugin to Listener
Converted EnchantedGemDialogue to DialogueFile
2022-07-03 06:32:03 +00:00
Ceikry
c4781e8000 Reworked grand exchange offer processing
Now much more efficient
Offers will appear to complete almost instantaneously
Players can no longer hoard bot offers as they will only be allocated at time of offer placement
2022-07-03 06:24:59 +00:00
ceikry
81a12534be Clean step is DEAD 2022-07-02 20:08:19 +00:00
vddcore
534f568ef0 Fixed incorrect banker NPC look-up behavior for bank booths
Banker interactions are now properly restricted for Ultimate Ironmen
Added theme-appropriate banker NPCs to booths at Void Knights' Outpost Island
Added missing Canifis banker NPCs
Fixed incorrect handling of Arnold Lydspor banking-related logic
Added Arnold Lydspor dialogue
Consolidated banker NPC listener logic into BankerNPC class itself
Added ContentAPI call to check if a node offers an interaction option
2022-07-02 09:46:24 +00:00
Ceikry
fdf8e3ea1b Fixed exception thrown by an interaction with Ahab's beer 2022-07-02 08:34:18 +00:00
Ceikry
931409ba97 Fixed exception occurring when an NPC has no jobs that can be assigned to the player
Fixed an issue that caused killing jobs not to work without relogging first
2022-07-02 07:54:27 +00:00
Ceikry
6dd30896f0 Fixed a bug where an NPC could not attack an entity that was already set as their target
Fixed a regression that prevents some NPCs from walking back to their spawn point
Fixed a longstanding issue that didn't properly reset NPCs who wandered too far out of their natural movement radius (now disables combat + walks them back to their spawn point + fully heals them)
2022-07-02 07:48:46 +00:00
Ceikry
c23c7d0617 Fixed bug where trying to buy-x too many items from a shop would not fill available inventory slots 2022-06-29 12:29:37 +00:00
Ceikry
f29d7e37de Rewrote animal magnetism cutscene in the new cutscene system
Fixes bug where the player could not progress
2022-06-29 12:09:06 +00:00
Coaltong
bdf4b48388 Fixed Rock Golem random event not spawning for low level players 2022-06-29 12:06:32 +00:00
Ceikry
31ecd20911 Fixed an issue where lighting a lantern (or other light source) inside a dark area wouldn't be recognised 2022-06-29 09:12:10 +00:00
downthecrop
a753db5ed7 Rewrote enchanted jewellery
Fixes the funny bug that gets you stuck as a tiny person when teleporting sometimes
2022-06-29 08:51:09 +00:00
Ceikry
e429b15911 Fixed exception thrown when invalid fairy ring codes are entered
Fixed unhandled hairdresser button that lead to OOB exception
Fixed oversight in ::loc that causes exceptions to be thrown in headless environments
2022-06-27 14:21:50 +00:00
Ceikry
95414bc02b Increased server stability
Fixed NPE in IoEventHandler
Fixed NPEs in PacketWriteQueue
Reworked PacketWriteQueue slightly so that instead of breaking at first null packet we continue past it and pop the whole queue along the way
2022-06-27 14:09:44 +00:00
vddcore
ee5bc78b62 Refactored item note/unnote on bank booth handling
QoL - only applies to bank booth, not banker NPCs
Added server config world.bank_booth_note_enabled (enabled by default) to toggle the QoL globally
Added server config world.bank_booth_note_uim (enabled by default) to toggle the QoL on ultimate ironmen only
2022-06-27 14:06:47 +00:00
Ceikry
d38f7d4282 ContentAPI methods now all take 2nd bank into account 2022-06-27 12:58:13 +00:00
ceikry
cee4f7b072 Fixed a bug where NPCs couldn't be attacked against walls 2022-06-27 12:41:39 +00:00
Ceikry
2eb69ad54a Made wilderness NPCs immune to aggression tolerance
Unified wilderness and standard death code, wilderness death code now only rolls the extra loot drops
Fixed a bug that would cause revenant/player combat levels to sometimes be calculated incorrectly
2022-06-27 12:34:02 +00:00
Ceikry
9a2a2fe49d Set user join date in database again on account creation 2022-06-27 11:28:29 +00:00
Eli Stone
278944b892 Fixed shield of arrav progression getting stuck, can now talk to tramp if you haven't joined a gang 2022-06-25 04:15:19 +00:00
skelsoft
43479e23f6 Fremennik Easy Diary is now completable and Fremennik sea boots 1 can now be obtained
PickUpEvent Event Hook created, for events that need to fire when player picks up a specific item
All currently implemented Diary tasks where the player must pick up items have been converted to use the new PickUpEvent event hook
New zone created for the windswept tree (highest tree in the Fremennik area task) for its diary task
Rough dialogue created for obtaining your completed diary reward from Council Worker
2022-06-25 04:11:08 +00:00
skelsoft
49a6c833af Slayer expansion
Sumona (NPC ID 7880) now implemented as a Slayer Master
Sumona slayer task pool created, 1:1 with the task weights on the RSWiki
Sumona NPC spawn added
All slayer master task pools have been re-ordered alphabetically to match both live game wiki's task ordering
Slayer task pools have been audited to ensure weights are correct
Unimplemented tasks added to task tables but disabled
Elves now added as a Slayer task, players can find them at Elf Camp and Lletya
Elf slayer task added to task pool of Chaeldar and Duradel (as well as the new Sumona pool)
Added Fremennik easy diary NPCs
2022-06-25 03:11:57 +00:00
Ceikry
8ec8666605 Disabled aggression tolerance for GWD minion NPCs 2022-06-24 14:47:58 +00:00
Ceikry
ebf2ed4ab4 New server config option to preload the world map on boot, removes lag caused by lazy loading (server.preload_map = true)
Cached region clipping flags for faster lookups
Minor optimizations to setAttribute codepath which avoids unnecessary checks
Fixed a bug that would allow entities to attack through walls
Fixed two separate bugs that would cause odd behavior attacking large entities from certain angles
Removed unnecessary schema from global.sql
Ensured that all but the `members` and `worlds` tables could be safely dropped out of the DB
Better automatic handling for creating the default server account and creating the default server clan
Fixed bugs related to interfaces flagged as uncloseable that would cause stack overflows
Fixed premature home teleport while in tutorial
Fixed getting stuck by going back up ladder in tutorial
Fixed bug that prevented bots from taking damage
Fixed a bug where players would not be in the default clan after completion of the tutorial
Green Dragon bots reintroduced, no longer buy any items (these bots sell loot from green dragons in the wilderness on the GE)
2022-06-24 14:40:26 +00:00
Ceikry
67e54d5429 Teleblock now persists across login sessions 2022-06-23 23:29:05 +00:00
Ceikry
419533e6c8 Added support for many common variations of the jagex coordinate format for admin command ::tele, including:
regionX_regionY
plane_regionX_regionY
regionX_regionY_localX_localY
plane_regionX_regionY_localX_localY
2022-06-23 23:27:36 +00:00
Coaltong
01c8072e9b Fixed tree spirit random event not spawning for some players 2022-06-23 23:17:29 +00:00
vddcore
385a04a5b9 ::rolldrops admin/testing command now clears container between invocations 2022-06-23 23:11:10 +00:00
Ceikry
5cfe44d5cd Implemented pelting of rotten tomatoes
Added ability to define listeners for Player interactions and usewith interactions
Added ability to flag listeners instant (no path walking) execution
2022-06-23 14:25:23 +00:00
bushtail
c3a37d5cbf Add slayer task content API functions in preparation for coming work 2022-06-23 14:06:58 +00:00
vddcore
b094fe5b0c Rewrote entire banking system (aside from dialogue), converted to listener system 2022-06-23 13:31:17 +00:00
Ceikry
40dd58d610 Fixed many issues with login
Reconnecting to an existing session can no longer cause an account wipe
Player saves can no longer be saved unless they've already been parsed
Sessions now have their most recent ping properly set
Sessions can now recover from a hypothetical scenario where the session's player reference becomes null but the player is still in-game
Players now disconnected properly if no packets have been received from the client in the last 20 seconds
2022-06-19 23:20:01 +00:00
Ceikry
f503d710ab Reduced revenant spawn burst size to stop them getting stuck
Fixed unit test NPE
New admin command clearrevs to clear revenants
2022-06-18 16:22:25 +00:00
Ceikry
b2ad6d9712 GE offer notification system now supports opt-in privacy to remove username from messages
Opt-in to GE privacy with new in-game command ::geprivacy on
Removed discord GE offer update notifications (only new buy/sell offers shown)
Limited in-game GE notifications to player offers only
2022-06-18 14:04:50 +00:00
Ceikry
6d12982b76 Discord GE offer notifications via webhook
This is disabled by default unless server config server.discord_webhook is set to a discord webhook URL
2022-06-18 02:36:59 +00:00
skelsoft
ce14aa0e80 Over 30+ monsters with added sfx, tick respawn fixes, and stat corrections
Unicorn (ID 89, 987) Unicorn Foal (ID 1328) and Unicorn stallion (ID 6822, 6823) combat sfx added
Unicorn (ID 89) respawn delay corrected (90 ticks/54 seconds)
Unicorn Foal (ID 1328) stats, attack speed, and respawn delay corrected (90 ticks/54 seconds)
Black unicorn (ID 133) and Black unicorn foal (ID 1329) combat sfx added
Black unicorn (ID 133) stats, attack speed, and respawn delay corrected (90 ticks/54 seconds)
Black unicorn Foal (ID 1329) stats, attack speed and respawn delay corrected (20 ticks/12 seconds)
Angry unicorn (ID 3646, 3661) combat sfx added
Angry unicorn (ID 3646, 3661) stats and attack speed corrected
Rock Crab (ID 1265, 1267) and Giant Rock Crab (ID 2452, 2885) combat sfx added
Rock Crab (ID 1265, 1267) attack speed and respawn delay corrected (50 ticks/30 seconds)
Giant Rock Crab (ID 2452, 2885) stats, attack speed and respawn delay corrected (50 ticks/30 seconds)
Ice giant (ID 111, 3072, 4685, 4686, 4687) combat sfx added
Ice giant (ID 111, 3072, 4685, 4686, 4687) respawn delay corrected (30 ticks/18 seconds)
Ice warrior (ID 125, 145, 3073) combat SFX added
Ice warrior (ID 125, 145, 3073) respawn delay corrected (30 ticks/18 seconds)
Basilisk (ID 1616, 1617, 4228) combat SFX added
Basilisk (ID 1616, 1617, 4228) stats, attack speed and respawn delay corrected (15 ticks/9 seconds)
Al-Kharid warrior (ID 18) combat sfx added
Al-Kharid warrior (ID 18) stats, attack speed and respawn delay corrected (25 ticks/15 seconds)
Magic axe (ID 127) combat sfx added, as well as its combat bonii corrected
Chaos dwarf (ID 119) combat sfx added
Black Knight (ID 178, 179, 6189) combat sfx added
Black Knight (ID 178, 179, 6189) stats, attack speed and respawn delay corrected (25 ticks/15 seconds)
Giant bat (ID 78, 1005, 2482, 3711) combat sfx added
Giant bat (ID 78, 1005, 2482, 3711) stats, attack speed, and respawn delay corrected (35 ticks/21 seconds)
Grizzly bear (ID 105, 1195) combat sfx added
Grizzly bear (ID 105) combat level 21 stats, attack speed, and respawn delay corrected (50 ticks/30 seconds)
Grizzly bear (ID 1195) combat level 42 stats, attack speed and respawn delay corrected (50 ticks/30 seconds)
Black bear (ID 106) combat sfx added
Black bear (ID 106) stats, attack speed and respawn delay corrected (50 ticks/30 seconds)
Cave horror (ID 4353, 4354, 4355, 4356, 4357) combat sfx added
Cave horror (ID 4353, 4354, 4355, 4356, 4357) respawn delay corrected (50 ticks/30 seconds)
Jungle horror (ID 4348, 4349, 4350, 4351, 4352) combat sfx added
Jungle horror (ID 4348, 4349, 4350, 4351, 4352) stats, attack speed and respawn delay corrected (50 ticks/30 seconds)
Hobgoblin (Spear-wielding) (ID 123, 2688, 4898) combat sfx added
Waterfiend (ID 5361) combat sfx added
Waterfiend (ID 5361 stats and attack speed corrected
Banshee (ID 1612) combat sfx added
Banshee (ID 1612) stats, attack speed and respawn delay corrected (15 ticks/9 seconds)
Angry bear (ID 3645, 3664) combat sfx added
Angry bear (ID 3645, 3664) stats and attack speed corrected
Seagull (ID 2707, 6115, 6116) combat sfx added
Ghast (ID 1052, 1053) combat sfx added
Icefiend (ID 3406, 6217, 7714, 7715) combat sfx added
Jackal (ID 1994) combat sfx added
Jackal (ID 1994) stats, attack speed and respawn delay corrected (50 ticks/30 seconds)
Kalphite Soldier (ID 1154, 3589) combat sfx added
Kalphite Worker (ID 1153, 1156) combat sfx added
Vulture (ID 3675, 3676) combat sfx added
Vulture (ID 3675, 3676) stats, attack speed and respawn delay corrected (50 ticks/30 seconds)
Chompy bird (ID 1550) combat sfx added
Chompy bird (ID 1550) stats, examine, and poison immunity corrected
Minotaur (ID 4404, 4405, 4006) combat sfx added
Minotaur (ID 4404, 4405) stats, attack speed, examine, and respawn delay corrected (15 ticks/9 seconds)
Minotaur (ID 4006) combat level 27 stats, attack speed, examine, and respawn delay corrected (15 ticks/9 seconds)
Penance Fighter (ID 5040) combat sfx added
Skeletal Wyvern (ID 3068, 3069, 3070, 3071) combat sfx added (TODO: attack sound check)
Harpie Bug Swarm (ID 3153) combat sfx added
Harpie Bug Swarm (ID 3153) stats, attack speed and respawn delay corrected (25 ticks/15 seconds)
Harpie Bug Swarm (ID 3153) now correctly attacks with Melee
Molanisk (ID 5751) combat sfx added
Molanisk (ID 5751) stats and attack speed corrected
Mudskipper (ID 3422, 3423) combat sfx added
Mudskipper (ID 3422) combat level 30 stats, attack speed and respawn delay corrected (10 ticks/6 seconds)
Mudskipper (ID 3423) combat level 31 stats, attack speed and respawn delay corrected (5 ticks/3 seconds)
Aberrant spectre (ID 1604, 1605, 1606, 1607) combat sfx added
Aberrant spectre attack speed corrected
Cave slime (ID 1831) combat sfx added
Cave slime (ID 1831) stats, poison amount, attack speed and respawn delay corrected (15 ticks/9 seconds)
Stag (ID 4440) combat sfx added
Stag (ID 4440) stats, attack speed and respawn delay corrected (90 ticks/54 seconds)
Terrorbird (ID 138, 139, 1751) combat sfx added
Terrorbird (ID 138, 139, 1751) stats, attack speed and respawn delay corrected (30 ticks/18 seconds)
Chaos Elemental (ID 3200) respawn delay corrected (100 ticks/60 seconds)
General Graardor (ID 6260) respawn delay corrected (150 ticks/90 seconds)
Sergeant Grimspike (ID 6265) Ranged Strength bonus corrected
Commander Zilyana (ID 6247) respawn delay corrected (150 ticks/90 seconds)
Starlight (ID 6248) attack speed and poison immunity corrected
Kree'arra (ID 6222) respawn delay corrected (150 ticks/90 seconds)
Wingman Skree (ID 6223) poison immunity corrected
Flockleader Geerin (ID 6225) poison immunity corrected
K'ril Tsutsaroth (ID 6203) poison amount and respawn delay corrected (150 ticks/90 seconds)
Zakl'n Gritch (ID 6206) ranged strength bonus corrected
2022-06-17 17:36:13 +00:00
downthecrop
8d98fbfd57 Intentionally burning seaweed->soda ash will now stop at specified Make-X 2022-06-16 23:20:07 +00:00
skelsoft
01639d0e61 GWD Boss Drop Tables Corrected
K'ril Tsutsaroth (Zamorak GWD) Drop Changes:
Zamorakian spear droprate corrected to ~1/512
Steam battlestaff droprate corrected to ~1/512
Godsword shard 1, 2 and 3 droprate corrected to ~1/768
Dragon dagger (p++) droprate corrected to ~1/63
Clue scroll (hard) droprate corrected to ~1/128
RDT roll corrected to ~1/128
Erroneous Nothing drop removed

General Graardor (Bandos GWD) Drop Changes:
Bandos tassets, chestplate, and boots droprate corrected to ~1/381
Bandos hilt droprate corrected to ~1/512
Godsword shard 1, 2 and 3 droprate corrected to ~1/768
Long bone droprate corrected to ~1/400
Curved bone droprate corrected to ~1/5000
Clue scroll (hard) droprate corrected to ~1/128
RDT roll corrected to ~1/128
Erroneous Nothing drop removed

Kree'arra (Armadyl GWD) Drop Changes:
Armadyl helmet, chestplate, and plateskirt droprate corrected to ~1/381
Armadyl hilt droprate corrected to ~1/512
Godsword shard 1, 2 and 3 droprate corrected to ~1/768
Long bone droprate corrected to ~1/400
Curved bone droprate corrected to ~1/5000
Clue scroll (hard) droprate corrected to ~1/128
RDT roll corrected to ~1/128
Erroneous Nothing drop removed
Erroneous 1-20 Shark drop removed

Zilyana (Saradomin GWD) Drop Changes:
Saradomin hilt droprate corrected to ~1/512
Saradomin sword droprate corrected to ~1/128
Godsword shard 1, 2 and 3 droprate corrected to ~1/768
Clue scroll (hard) droprate corrected to ~1/128
RDT roll corrected to ~1/128
Erroneous Nothing drop removed
2022-06-16 23:16:05 +00:00
vddcore
5830309ded Added Maven exec plugin to the server build
Now possible to use the debugger again. Instructions for use will be added in the upcoming README refactor (in short, add a maven build config that runs "compile exec:java")
2022-06-16 12:23:04 +00:00
bushtail
c5d0173282 Converted some Al-Kharidian NPCs to listeners:
Ali the Leaflet Dropper
A'abla
Fadli
Surgeon General Tafani
Sabreen
Jaraah
2022-06-16 10:29:02 +00:00
Ceikry
0e74cf0495 Revenants have been reworked to feel much more present, more alive and more dangerous - Beware!
Revenant spawns, patrols and areas of exploration are now based on era-authentic maps
New revenant command for admins ::setrevcap to set max number of revenants
New server config world option revenant_population
2022-06-13 12:47:15 +00:00
vddcore
053edc3f34 Fixed character misgendering themselves during secondary bank account opening dialogue 2022-06-13 07:26:10 +00:00
skelsoft
49f3d3cff3 Overhauled and analysed the shooting star locations to match authentic data from the era
East of Dark Wizards' Tower location added
Jatiszo mine location added
Lunar Isle mine location added
Miscellania coal mine location added
Neitiznot runite mine location added
Ardougne mining site (Legends Guild) location added
Kandarin Coal Trucks location added
Port Khazard mine location added
Kharidian desert clay mine location added
Granite and sandstone quarry location added
Burgh de Rott bank location added
Mos Le'Harmless bank location added
Lletya bank location added (requires Roving Elves to be completed)
Piscatoris mining site location added
Wilderness Volcano bank location added
Wilderness hobgoblin mine location added
2022-06-13 06:01:54 +00:00
skelsoft
8fc32f3a77 Revenant drop tables reworked
Removed erroneous Nothing drop inside all revenant drop tables, which made them drop Nothing at all 80% of the time
Added back Nothing drop to each revenant's Charm table, so they don't drop charms 100% of the time
Bumped down number of adamantite ore dropped from 1-75 to 1-5, and reduced their drop rate so they are much rarer
Adjusted number of Uncut diamond to maximum of 5 (down from 50)
Changed Gold bar drop to ore drop, and reduced maximum amount to 10-30
Adjusted strength potion drop to 1-4
Adjusted grimy ranarr drop to 1-10 (from 1-15)
Adjusted grimy toadflax drop to 1-10 (from 5-15)
Adjusted amount of Law, Blood and Death runes dropped to 15-200 (from 50-500)
Removed 1000-15000 spirit shards drop
Removed noted 100-500 Iron Ore drop
Removed noted 50-250 Coal drop
Removed dragon platelegs and plateskirt drops
Removed ring of wealth drop
Removed dragon boots drop
All amulet of glory drops are now uncharged amulet of glory
Adjusted Yew, Magic, Snapdragon, Palm Tree and papaya seed to only drop a maximum of 1 seed at a time, and reduced their drop weight so they are much rarer
Limited tuna potato drop to a maximum of 5
Adjusted weight of Yew logs drop to be higher (filler drop)
Runite bolts reduced to 50 (from 100)
Adamant bolts reduced to 75 (from 300)
Rune arrows reduced to 75 (from 150)
Removed 10-500 snape grass drop
2022-06-13 05:59:02 +00:00
Coaltong
c54abe696c Implemented Falador farm sheepdog interactions, can now be fed bones and meat 2022-06-13 05:02:23 +00:00