2009Scape/Server
1
0
Fork 1
mirror of https://gitlab.com/2009scape/2009scape.git synced 2025-12-16 03:20:19 -07:00
Code Issues Projects Releases Packages Wiki Activity

Fixed bug that could cause bank to throw index out of bounds and vanish items when rearranging tabs with completely full bank

Browse source
This commit is contained in:
Ceikry 2022-07-03 07:23:47 +00:00 • committed by Ryan
parent 2846ff7172
commit f94fb24608
1 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Server/src/main/java/core/net/packet/in/SlotSwitchPacket.java
View file

@ -39,6 +39,14 @@ public class SlotSwitchPacket implements IncomingPacket {
int tabIndex = BankContainer.getArrayIndex(withChildId); int tabIndex = BankContainer.getArrayIndex(withChildId);
if (tabIndex > -1) { if (tabIndex > -1) {
secondSlot = tabIndex == 10 ? player.getBank().freeSlot() : player.getBank().getTabStartSlot()[tabIndex] + player.getBank().getItemsInTab(tabIndex); secondSlot = tabIndex == 10 ? player.getBank().freeSlot() : player.getBank().getTabStartSlot()[tabIndex] + player.getBank().getItemsInTab(tabIndex);
Item inSlot = player.getBank().get(slot);
if (secondSlot == -1 && player.getBank().remove(inSlot)) {
player.getBank().add(inSlot);
return;
}
childId = player.getBank().getTabByItemSlot(slot); childId = player.getBank().getTabByItemSlot(slot);
if (secondSlot > slot) { if (secondSlot > slot) {
player.getBank().insert(slot, secondSlot - 1); player.getBank().insert(slot, secondSlot - 1);