From a5f94d736a0ee4dada8885f52b0fa429fc14b406 Mon Sep 17 00:00:00 2001
From: Ceikry <ironceikry@gmail.com>
Date: Wed, 1 Mar 2023 03:24:17 +0000
Subject: [PATCH] Fixed incorrect xp calculation that would occur in some
 circumstances when training magic

---
 .../main/core/game/node/entity/combat/spell/MagicSpell.java  | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Server/src/main/core/game/node/entity/combat/spell/MagicSpell.java b/Server/src/main/core/game/node/entity/combat/spell/MagicSpell.java
index 53d017c75..8a052aafc 100644
--- a/Server/src/main/core/game/node/entity/combat/spell/MagicSpell.java
+++ b/Server/src/main/core/game/node/entity/combat/spell/MagicSpell.java
@@ -314,8 +314,9 @@ public abstract class MagicSpell implements Plugin<SpellType> {
 		}
 		entity.getSkills().addExperience(Skills.HITPOINTS, hit * 1.33, true);
 		if (entity.getProperties().getAttackStyle().getStyle() == WeaponInterface.STYLE_DEFENSIVE_CAST) {
-			entity.getSkills().addExperience(Skills.DEFENCE, hit, true);
-			entity.getSkills().addExperience(Skills.MAGIC, 1.33 * hit, true);
+			double baseXpReward = hit / 2.0;
+			entity.getSkills().addExperience(Skills.DEFENCE, baseXpReward, true);
+			entity.getSkills().addExperience(Skills.MAGIC, baseXpReward * 1.33, true);
 			return;
 		}
 		entity.getSkills().addExperience(Skills.MAGIC, hit * (CombatSwingHandler.EXPERIENCE_MOD / 2), true);