2009Scape/Server
1
0
Fork 1
mirror of https://gitlab.com/2009scape/2009scape.git synced 2025-12-09 16:45:44 -07:00
Code Issues Projects Releases Packages Wiki Activity

Fixed incorrect ordering of operations when opening the bank

Browse source 
Somewhat improved sending of tab configurations and free space
This commit is contained in:
Player Name 2025-11-10 12:10:44 +00:00 • committed by Ryan
parent f9a193c8d7
commit 789466e4ab
1 changed files with 12 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

25
Server/src/main/core/game/container/impl/BankContainer.java
View file

@ -153,17 +153,16 @@ public final class BankContainer extends Container {
BankContainer.this.close(); BankContainer.this.close();
return true; return true;
}); });
refresh(listener);
player.getInterfaceManager().openSingleTab(new Component(763)); player.getInterfaceManager().openSingleTab(new Component(763));
player.getInventory().getListeners().add(player.getBank().listener); refresh(listener);
player.getInventory().refresh(); player.getInventory().refresh();
setVarp(player, 1249, lastAmountX); player.getInventory().getListeners().add(player.getBank().listener);
setVarp(player, 1249, lastAmountX);
player.getPacketDispatch().sendIfaceSettings(1278, 73, 762, 0, SIZE); player.getPacketDispatch().sendIfaceSettings(1278, 73, 762, 0, SIZE);
int settings = new IfaceSettingsBuilder().enableOptions(new IntRange(0,5)).enableExamine().enableSlotSwitch().build(); int settings = new IfaceSettingsBuilder().enableOptions(new IntRange(0,5)).enableExamine().enableSlotSwitch().build();
player.getPacketDispatch().sendIfaceSettings(settings, 0, 763, 0, 27); player.getPacketDispatch().sendIfaceSettings(settings, 0, 763, 0, 27);
player.getPacketDispatch().sendRunScript(1451, ""); player.getPacketDispatch().sendRunScript(1451, "");
open = true; open = true;
} }
/** /**
@ -281,7 +280,7 @@ public final class BankContainer extends Container {
*/ */
public void updateLastAmountX(int amount) { public void updateLastAmountX(int amount) {
this.lastAmountX = amount; this.lastAmountX = amount;
setVarp(player, 1249, amount); setVarp(player, 1249, amount);
} }
/** /**
@ -414,7 +413,7 @@ public final class BankContainer extends Container {
* @return If items have to be noted {@code true}. * @return If items have to be noted {@code true}.
*/ */
public boolean isNoteItems() { public boolean isNoteItems() {
return getVarbit(player, Vars.VARBIT_IFACE_BANK_NOTE_MODE) == 1; return getVarbit(player, Vars.VARBIT_IFACE_BANK_NOTE_MODE) == 1;
} }
/** /**
@ -422,7 +421,7 @@ public final class BankContainer extends Container {
* @param noteItems If items have to be noted {@code true}. * @param noteItems If items have to be noted {@code true}.
*/ */
public void setNoteItems(boolean noteItems) { public void setNoteItems(boolean noteItems) {
setVarbit(player, Vars.VARBIT_IFACE_BANK_NOTE_MODE, noteItems ? 1 : 0, true); setVarbit(player, Vars.VARBIT_IFACE_BANK_NOTE_MODE, noteItems ? 1 : 0, true);
} }
/** /**
@ -456,7 +455,7 @@ public final class BankContainer extends Container {
* @param insertItems The insert items value. * @param insertItems The insert items value.
*/ */
public void setInsertItems(boolean insertItems) { public void setInsertItems(boolean insertItems) {
setVarbit(player, Vars.VARBIT_IFACE_BANK_INSERT_MODE, insertItems ? 1 : 0, true); setVarbit(player, Vars.VARBIT_IFACE_BANK_INSERT_MODE, insertItems ? 1 : 0, true);
} }
/** /**
@ -464,7 +463,7 @@ public final class BankContainer extends Container {
* @return {@code True} if inserting items mode is enabled. * @return {@code True} if inserting items mode is enabled.
*/ */
public boolean isInsertItems() { public boolean isInsertItems() {
return getVarbit(player, Vars.VARBIT_IFACE_BANK_INSERT_MODE) == 1; return getVarbit(player, Vars.VARBIT_IFACE_BANK_INSERT_MODE) == 1;
} }
/** /**
@ -498,22 +497,22 @@ public final class BankContainer extends Container {
public void update(Container c, ContainerEvent event) { public void update(Container c, ContainerEvent event) {
if (c instanceof BankContainer) { if (c instanceof BankContainer) {
PacketRepository.send(ContainerPacket.class, new ContainerContext(player, 762, 64000, 95, event.getItems(), false, event.getSlots())); PacketRepository.send(ContainerPacket.class, new ContainerContext(player, 762, 64000, 95, event.getItems(), false, event.getSlots()));
player.getBank().setTabConfigurations();
player.getBank().sendBankSpace();
} else { } else {
PacketRepository.send(ContainerPacket.class, new ContainerContext(player, 763, 64000, 93, event.getItems(), false, event.getSlots())); PacketRepository.send(ContainerPacket.class, new ContainerContext(player, 763, 64000, 93, event.getItems(), false, event.getSlots()));
} }
player.getBank().setTabConfigurations();
player.getBank().sendBankSpace();
} }
@Override @Override
public void refresh(Container c) { public void refresh(Container c) {
if (c instanceof BankContainer) { if (c instanceof BankContainer) {
PacketRepository.send(ContainerPacket.class, new ContainerContext(player, 762, 64000, 95, c.toArray(), c.capacity(), false)); PacketRepository.send(ContainerPacket.class, new ContainerContext(player, 762, 64000, 95, c.toArray(), c.capacity(), false));
player.getBank().setTabConfigurations();
player.getBank().sendBankSpace();
} else { } else {
PacketRepository.send(ContainerPacket.class, new ContainerContext(player, 763, 64000, 93, c.toArray(), 28, false)); PacketRepository.send(ContainerPacket.class, new ContainerContext(player, 763, 64000, 93, c.toArray(), 28, false));
} }
player.getBank().setTabConfigurations();
player.getBank().sendBankSpace();
} }
} }
} }